Skip to content

bpo-31285: Remove splitlines identifier from Python/_warnings.c (forgot to remove it in #3219) #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

bpo-31285: Remove splitlines identifier from Python/_warnings.c (forgot to remove it in #3219) #3803

merged 1 commit into from
Sep 29, 2017

Conversation

orenmn
Copy link
Contributor

@orenmn orenmn commented Sep 28, 2017 •
edited by bedevere-bot
Loading

#3219 removed the only use of the splitlines identifier in Python/_warnings.c, so it should be completely removed.

https://bugs.python.org/issue31285

@orenmn orenmn mentioned this pull request Sep 28, 2017
Closed
@serhiy-storchaka serhiy-storchaka merged commit 8b4ff53 into python:master Sep 29, 2017
@miss-islington
Copy link
Contributor

Thanks @orenmn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-3829 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2017
@orenmn @miss-islington
[3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (…
3c3e62c 
…pythonGH-3803)

(forgot to remove it in pythonGH-3219)
(cherry picked from commit 8b4ff53)
serhiy-storchaka pushed a commit that referenced this pull request Sep 29, 2017
@miss-islington @serhiy-storchaka
[3.6] bpo-31285: Remove splitlines identifier from Python/_warnings.c (…
66c2b9f 
…GH-3803) (#3829)

(forgot to remove it in GH-3219)
(cherry picked from commit 8b4ff53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orenmn @miss-islington @bedevere-bot @serhiy-storchaka @Mariatta @the-knights-who-say-ni