Closes bpo-28281: Remove year (1-9999) limits on the weekday() function. #4109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/calendar.py
Outdated
| @@ -111,8 +111,10 @@ def leapdays(y1, y2): | |||
|
|
|||
|
|
|||
| def weekday(year, month, day): | |||
| """Return weekday (0-6 ~ Mon-Sun) for year (1970-...), month (1-12), | |||
| day (1-31).""" | |||
| """Return weekday (0-6 ~ Mon-Sun) for year (MINYEAR-MAXYEAR), | |||
There was a problem hiding this comment.
But this patch makes years out of range MINYEAR-MAXYEAR be supported.
|
@taleinat - yes, according to the bpo, Mark Gollahon has signed a CLA. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 29, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2024
The limit was removed in 66c88ce (pythonGH-4109). (cherry picked from commit 0f54ee4) Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2024
The limit was removed in 66c88ce (pythonGH-4109). (cherry picked from commit 0f54ee4) Co-authored-by: Steven Ward <planet36@users.noreply.github.com>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 29, 2024
serhiy-storchaka
pushed a commit
that referenced
this pull request
Jan 29, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
The limit was removed in 66c88ce (pythonGH-4109).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A patch by Mark Gollahon.
https://bugs.python.org/issue28281