-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Misc. typos #4275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc. typos #4275
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2770,7 +2770,7 @@ def __init__(self): | |
import signal | ||
self.signal = signal | ||
self.signals = list(range(1, signal.NSIG)) | ||
# SIGKILL and SIGSTOP signals cannot be ignored nor catched | ||
# SIGKILL and SIGSTOP signals cannot be ignored nor caught | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 'catched' might be a misspelling of 'cached' rather than 'caught'. Victor Stinner might be the one who knows. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this edit is correct: "caught" was intended. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops, irregular verb: caught is correct ;-) |
||
for signame in ('SIGKILL', 'SIGSTOP'): | ||
try: | ||
signum = getattr(signal, signame) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the same typo in
Lib/test/test_threading.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serhiy-storchaka apologies, are you saying that
daemons
is correct here?and in regards to
Lib/test/test_threading.py
i should fix:cpython/Lib/test/test_threading.py
Line 430 in 1023dbb
so that it shows:
def test_daemon_param(self):