bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS. #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip some tests of select.poll when running on macOS due to unresolved issues with the underlying system poll function on some macOS versions.
|
@ned-deily, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @giampaolo, @cf-natali, @ezio-melotti and @tiran to be potential reviewers. |
ned-deily
added a commit
to ned-deily/cpython
that referenced
this pull request
Mar 4, 2017
…ython#462) * bpo-28087: Skip test_asyncore and test_eintr poll failures on macOS Skip some tests of select.poll when running on macOS due to unresolved issues with the underlying system poll function on some macOS versions. (cherry picked from commit de04644)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
We upgraded the redis environment on Heroku a couple days ago. In the new environment, the REDIS_URL environment variable was changed to HEROKU_REDIS_MAROON_TLS_URL. Updated the code where we were hardcoding it to the old to url. Fixes #462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip some tests of select.poll when running on macOS due to unresolved issues with the underlying system poll function on some macOS versions.