bpo-32226: PEP 560: improve typing module #4906

ilevkivskyi · 2017-12-16T21:47:45Z

This is not ready for a detailed review, but updates to tests can be already discussed. You can also play with the new implementation but some minor details can change.

Here is the summary of changes in tests (two first are mentioned in the PEP):

issublcass(List[int], List) etc. raise TypeError instead of returning True as before.
repr() for unsubscripted generics coincides with repr() for normal (non-generic) classes, like
<class '__main__.MyGeneric'>. However all things in typing that are not class objects and all subscripted generics use existing "fancy" repr(), like typing.List[__main__.C[int]].
In view of PEP 563 I propose to remove leading underscore from ForwardRef, on the contrary, I add underscore to _Protocol until PEP 544 is accepted and the "real" Protocol is added to typing.
I removed most pieces of code that existed for backwards compatibility, since this version is only for Python 3.7

An important question is how will we keep stdlib version and the backport on PyPI in sync? One possible option is just manually copy useful updates/test between them.

cc: @gvanrossum

https://bugs.python.org/issue32226

…emoval

gvanrossum · 2018-01-17T00:41:35Z

I'm afraid I won't be able to look at this in time for 3.7b1. I trust Serhiy, so I think it's between the two of you.

As to which repo should be fixed first, I propose to do the CPython master branch first, backporting to 3.6 if appropriate, and only to the typing repo if it's relevant for Python 2.7. For 3.5 and 3.6 the typing repo isn't used anyways (except by people who set $PYTHONPATH), and 3.4 is no longer supported (may it rest in peace).

I assume that even Python 2.7 support will be minimal, but we should at least try to keep Protocol support up to date there, and perhaps other new features for which it makes sense. If we didn't have Python 2.7, I'd propose to just close the repo like we did for asyncio -- but I think we can't do that until the Python 2.7 EOL date of 1/1/2020.

This could even mean that we could sanitize the typing repo, removing the Python 3 support code. Though I'm not sure what to do with the issue tracker. Should we continue to point people there for fundamental discussions about the type system?

gvanrossum · 2018-01-17T00:42:33Z

For the other issues (including Union simplification) I would be happy to see small PRs, one per issue or feature.

ilevkivskyi · 2018-01-17T12:31:09Z

OK, @serhiy-storchaka would you like to make another pass of review? Note that one of the goals of this PR is to simplify the code, so that it is easier to understand, so it would be a good test. If there are some particularly tricky places in code, then you can just flag them, so that I will add comments there. Or you will not have time today/tomorrow then maybe we can just merge as is, to unblock other things that depend on this PR?

ilevkivskyi · 2018-01-20T10:56:00Z

@serhiy-storchaka If you don't have time to review this now, then I think we shouldn't wait more. I am going to merge this in an hour or so. Please let me know if you still want to review this.

serhiy-storchaka

I know too small about this module for making deep review, but at surface I don't see anything wrong. If there are some problems, I think they can be resolved at the beta stage in separate issues.

ilevkivskyi · 2018-01-20T11:21:32Z

OK.

eirrgang · 2019-08-30T16:02:06Z

This change did not update Doc/library/typing.rst but the note that "The metaclass used by :class:Generic is a subclass of :class:abc.ABCMeta." is no longer true, is it?

ilevkivskyi · 2019-09-02T09:52:54Z

@eirrgang You are right, there is no more metaclass for Generic (i.e. its metaclass is just type). Would you like to make a PR?

PR python#4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance.

eirrgang · 2019-10-08T10:05:05Z

@eirrgang You are right, there is no more metaclass for Generic (i.e. its metaclass is just type). Would you like to make a PR?

Uploaded #16646

PR python#4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance.

PR #4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance.

PR pythonGH-4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance. (cherry picked from commit d47f0dd) Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>

PR GH-4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance. (cherry picked from commit d47f0dd) Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>

PR pythonGH-4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance. (cherry picked from commit d47f0dd) Co-authored-by: M. Eric Irrgang <mei2n@virginia.edu>

PR python#4906 changed the typing.Generic class hierarchy, leaving an outdated comment in the library reference. User-defined Generic ABCs now must get a abc.ABCMeta metaclass from something other than typing.Generic inheritance.

ilevkivskyi and others added 30 commits November 11, 2017 10:01

POC implementation of __base_subclass__

26afdc6

POC implementation of __class_getitem__

3285fb6

Modify __base_subclass__ API to support dynamic evaluation and base r…

779f85d

…emoval

Make __base_subclass__ faster and safer

5d5211d

Factor out base update in a separate helper

41fa7e9

Formatting

5aeebab

Also make __class_getitem__ safer

e858ea7

Simplify some code

5b8d453

Initial work on typing2

b3e52f1

Remove test implementation for typing

6e7b575

Rename base_subclass to subclass_base

a8437fa

Start adding tests

c2d8ac2

Add tests for __subclass_base__

bc06c6b

Add tests for __class_getitem__

86c5d61

Fix trailing whitespace

2cef78a

Alternative implementation of __class_getitem__

b9bbf7c

Simplify code and fix reference counting

2495e94

Rename __base_subclass__ to __mro_entry__

9ca8dfc

Add types.resolve_bases

74bd36f

Make Python and C versions as similar as possible

6f20c45

More tests

bcfbcf6

Fail fast in type.__new__

d7bd630

Fix a test

29e54c3

Test error message

cba2a58

Test error message

966a9ea

Test error message

734c7e9

First sketches of typing refactoring

042760b

More work on new typing

450d66f

More fixes

e764c61

Return old _TypeAlias; more fixes

c75d80c

serhiy-storchaka reviewed Jan 20, 2018

View reviewed changes

ilevkivskyi merged commit d911e40 into python:master Jan 20, 2018

bedevere-bot removed the awaiting merge label Jan 20, 2018

ilevkivskyi deleted the new-typing branch January 20, 2018 11:24

tk0miya mentioned this pull request Jan 24, 2018

The result of format_annotation() has been changed with python 3.7.0a4+ sphinx-doc/sphinx#4490

Closed

ilevkivskyi mentioned this pull request May 18, 2018

bpo-32996: The bulk of What's New in Python 3.7 #6978

Merged

AiOO mentioned this pull request May 3, 2019

Compatibility issue with Python 3.7 nirum-lang/nirum-python#117

Open

eirrgang mentioned this pull request Oct 8, 2019

bpo-32996: Documentation fix-up. #16646

Merged

eirrgang mentioned this pull request Oct 8, 2019

[3.7] Documentation update for bpo-32996 fix (GH-16646) #16648

Closed

miss-islington mentioned this pull request Oct 10, 2019

[3.7] bpo-32996: Documentation fix-up. (GH-16646) #16696

Merged

miss-islington mentioned this pull request Oct 10, 2019

[3.8] bpo-32996: Documentation fix-up. (GH-16646) #16697

Merged

Slonegg mentioned this pull request Jun 24, 2020

Issue using Protocol as a base class with Python 3.5.2 python/typing#734

Closed

jjerphan mentioned this pull request May 5, 2023

Failing test suites for Python 3.6 on Linux man-group/ArcticDB#336

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-32226: PEP 560: improve typing module #4906

bpo-32226: PEP 560: improve typing module #4906

ilevkivskyi commented Dec 16, 2017 •

edited by bedevere-bot

Loading

gvanrossum commented Jan 17, 2018

gvanrossum commented Jan 17, 2018

ilevkivskyi commented Jan 17, 2018

ilevkivskyi commented Jan 20, 2018

serhiy-storchaka left a comment

ilevkivskyi commented Jan 20, 2018

eirrgang commented Aug 30, 2019

ilevkivskyi commented Sep 2, 2019

eirrgang commented Oct 8, 2019

bpo-32226: PEP 560: improve typing module #4906

bpo-32226: PEP 560: improve typing module #4906

Conversation

ilevkivskyi commented Dec 16, 2017 • edited by bedevere-bot Loading

gvanrossum commented Jan 17, 2018

gvanrossum commented Jan 17, 2018

ilevkivskyi commented Jan 17, 2018

ilevkivskyi commented Jan 20, 2018

serhiy-storchaka left a comment

Choose a reason for hiding this comment

ilevkivskyi commented Jan 20, 2018

eirrgang commented Aug 30, 2019

ilevkivskyi commented Sep 2, 2019

eirrgang commented Oct 8, 2019

ilevkivskyi commented Dec 16, 2017 •

edited by bedevere-bot

Loading