Skip to content

bpo-12706: timeout sentinel in ftplib and poplib documentation #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mwidjaja
Copy link
Contributor

@mwidjaja mwidjaja commented Jan 25, 2018

Original patch by Greg (εσχατοκυριος)

https://bugs.python.org/issue12706

@mwidjaja
Copy link
Contributor Author

Anyone has a cycle to review this PR? Thanks

@mwidjaja
Copy link
Contributor Author

hello, anyone can provide me with a review?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella
Copy link
Contributor

@mwidjaja, please address the code review. Thank you!

@csabella csabella added the stale Stale PR or inactive for long period of time. label Jan 25, 2020
@mwidjaja
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 24, 2023
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants