Skip to content

[3.6] bpo-32667: Fix tests when $PATH contains a file (GH-5322) #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 25, 2018

Some tests failed when the PATH environment variable contained a path
to an existing file. Fix tests to ignore also NotADirectoryError, not
only FileNotFoundError and PermissionError.
(cherry picked from commit b31206a)

https://bugs.python.org/issue32667

Some tests failed when the PATH environment variable contained a path
to an existing file. Fix tests to ignore also NotADirectoryError, not
only FileNotFoundError and PermissionError.
(cherry picked from commit b31206a)
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@vstinner vstinner merged commit 255dbd2 into python:3.6 Jan 25, 2018
@miss-islington
Copy link
Contributor Author

Thanks, @vstinner!

@miss-islington miss-islington deleted the backport-b31206a-3.6 branch January 25, 2018 21:39
@vstinner
Copy link
Member

You are welcome, darling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants