Skip to content

[3.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) #5824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

[3.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) #5824

merged 1 commit into from
Feb 23, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 23, 2018 •
edited by bedevere-bot
Loading

Make test.support.temp_cwd() fork-safe. The context manager test.support.temp_cwd() no longer removes the temporary directory when executing in a process other than the parent it entered from.
If a forked child exits the context manager it won't do the cleanup.
(cherry picked from commit 33dddac)

Co-authored-by: Anselm Kruis a.kruis@science-computing.de

https://bugs.python.org/issue30028

@miss-islington
bpo-30028: make test.support.temp_cwd() fork-safe (pythonGH-1066)
357ce94 
Make test.support.temp_cwd() fork-safe. The context manager test.support.temp_cwd() no longer removes the temporary directory when executing in a process other than the parent it entered from.
If a forked child exits the context manager it won't do the cleanup.
(cherry picked from commit 33dddac)

Co-authored-by: Anselm Kruis <a.kruis@science-computing.de>
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Feb 23, 2018
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2018
Merged
@miss-islington
Copy link
Contributor Author

@akruis and @gpshead: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 694c5e0 into python:3.7 Feb 23, 2018
@miss-islington
Copy link
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-33dddac-3.7 branch February 23, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot