Skip to content

Add two missing error checks in hamt.c #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2018
Merged

Add two missing error checks in hamt.c #5851

merged 2 commits into from
Mar 8, 2018

Conversation

zhangyangyu
Copy link
Member

No description provided.

@zhangyangyu zhangyangyu requested a review from 1st1 as a code owner February 24, 2018 16:53
@zhangyangyu zhangyangyu requested review from 1st1 and removed request for 1st1 February 24, 2018 16:53
@zhangyangyu zhangyangyu requested review from 1st1 and removed request for 1st1 March 8, 2018 05:05
1st1
1st1 reviewed Mar 8, 2018
View reviewed changes
Python/hamt.c Outdated
if (child_node == (PyHamtNode *)self) {
if (child_node == NULL) {
return NULL;
} else if (child_node == (PyHamtNode *)self) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reformat to

}
else if ...

(per PEP-7)

1st1
1st1 approved these changes Mar 8, 2018
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one nit. Thanks!

@zhangyangyu zhangyangyu merged commit 3c7ac7e into python:master Mar 8, 2018
@miss-islington
Copy link
Contributor

Thanks @zhangyangyu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zhangyangyu zhangyangyu deleted the hamt_error_check branch March 8, 2018 05:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2018
@zhangyangyu @miss-islington
Add two missing error checks in hamt.c (pythonGH-5851)
39f55c3 
(cherry picked from commit 3c7ac7e)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
@bedevere-bot
Copy link

GH-6025 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 8, 2018
@miss-islington @zhangyangyu
Add two missing error checks in hamt.c (GH-5851)
e724dd4 
(cherry picked from commit 3c7ac7e)

Co-authored-by: Xiang Zhang <angwerzx@126.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@zhangyangyu @jo2y
Add two missing error checks in hamt.c (pythonGH-5851)
21a4b99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangyangyu @miss-islington @bedevere-bot @1st1 @the-knights-who-say-ni