Skip to content

[3.6] bpo-30622: Fix NPN for OpenSSL 1.1.1-pre1 (GH-5876) #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2018
Merged

[3.6] bpo-30622: Fix NPN for OpenSSL 1.1.1-pre1 (GH-5876) #5881

merged 1 commit into from
Feb 25, 2018

Conversation

tiran
Copy link
Member

@tiran tiran commented Feb 25, 2018 •
edited by bedevere-bot
Loading

Signed-off-by: Christian Heimes christian@python.org.
(cherry picked from commit 29eab55)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue30622

@tiran
[3.6] bpo-30622: Fix NPN for OpenSSL 1.1.1-pre1 (pythonGH-5876)
8506ab2 
Signed-off-by: Christian Heimes <christian@python.org>.
(cherry picked from commit 29eab55)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Feb 25, 2018
Merged
@tiran tiran removed the skip issue label Feb 25, 2018
@tiran tiran merged commit a79591c into python:3.6 Feb 25, 2018
@bedevere-bot
Copy link

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@asergi
Copy link

asergi commented Mar 1, 2018 •
edited
Loading

@tiran this patch is incomplete:

2750 #ifdef HAVE_NPN
2751     self->npn_protocols = NULL;
2752 #endif

leads to a build error with LibreSSL>=2.6. [Fixed #6102]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiran @bedevere-bot @asergi @the-knights-who-say-ni