[3.4] bpo-33001: Prevent buffer overrun in os.symlink (GH-5989) #5992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@larryhastings FYI, but I'm still testing this one (don't keep VS 2010 handy these days, so it'll be a few hours). Don't rush to merge it |
|
So I'm skipping the test on 3.4, because the (older) CRT will abort the process on a buffer overrun with the newer methods. I've confirmed that it's definitely a safe abort, but we don't have any way to do this within the process or test suite, so skipping the test but leaving it in there as a reference seems like the best option. |
| } | ||
|
|
||
| /* Is this path absolute? */ | ||
| static int | ||
| _is_absW(const WCHAR *path) | ||
| { | ||
| return path[0] == L'\\' || path[0] == L'/' || path[1] == L':'; | ||
| return path[0] == L'\\' || path[0] == L'/' || | ||
| (path[0] && path[1] == L':'); |
|
@larryhastings: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33001