bpo-33204: IDLE: consistently color invalid string prefixes #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'u' string prefix cannot be paired with either 'r' or 'f'. Consistently color as much of the prefix, starting at the right, as is valid.
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
@terryjreedy: Please replace |
|
GH-6345 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
|
GH-6346 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
A 'u' string prefix cannot be paired with either 'r' or 'f'. Consistently color as much of the prefix, starting at the right, as is valid. (cherry picked from commit da58533) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
A 'u' string prefix cannot be paired with either 'r' or 'f'. Consistently color as much of the prefix, starting at the right, as is valid. (cherry picked from commit da58533) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
Followup to primary PR for the issue, pythonGH-6344. (cherry picked from commit 55966f3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2018
Followup to primary PR for the issue, pythonGH-6344. (cherry picked from commit 55966f3) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
added a commit
that referenced
this pull request
Apr 2, 2018
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'u' string prefix cannot be paired with either 'r' or 'f'. Consistently
color as much of the prefix, starting at the right, as is valid.
https://bugs.python.org/issue33204