Skip to content

bpo-33204: IDLE - revise and extend colorizer test #6347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2018
Merged

bpo-33204: IDLE - revise and extend colorizer test #6347

merged 1 commit into from
Apr 2, 2018

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Apr 2, 2018 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka reviewed Apr 2, 2018
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be worth to test also elif followed by a string literal. or, if and elif are the only keywords that can precede a literal string in syntactically correct code.

@terryjreedy terryjreedy merged commit 55966f3 into python:master Apr 2, 2018
@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-6348 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2018
@terryjreedy @miss-islington
bpo-33204: IDLE - revise and extend colorizer test. (pythonGH-6347)
1c489cd 
Followup to primary PR for the issue, pythonGH-6344.
(cherry picked from commit 55966f3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2018
@terryjreedy @miss-islington
bpo-33204: IDLE - revise and extend colorizer test. (pythonGH-6347)
480a557 
Followup to primary PR for the issue, pythonGH-6344.
(cherry picked from commit 55966f3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot
Copy link

GH-6349 is a backport of this pull request to the 3.6 branch.

@terryjreedy terryjreedy deleted the color-test branch April 2, 2018 15:22
@terryjreedy
Copy link
Member Author

I think not. If the re correctly splits one combination correctly, there is no reason it should not do the same with all similar combinations. " and'' " is also legal, as are " ''and'' " and " ''or'' ". I should better think about covering things that could independently fail, like multiline strings, and automating the test.

miss-islington added a commit that referenced this pull request Apr 2, 2018
@miss-islington @terryjreedy
bpo-33204: IDLE - revise and extend colorizer test. (GH-6347)
fa91aff 
Followup to primary PR for the issue, GH-6344.
(cherry picked from commit 55966f3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Apr 2, 2018
@miss-islington @terryjreedy
bpo-33204: IDLE - revise and extend colorizer test. (GH-6347)
306559e 
Followup to primary PR for the issue, GH-6344.
(cherry picked from commit 55966f3)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@serhiy-storchaka
Copy link
Member

Only these three keywords end with legal string prefixes (r or f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@terryjreedy @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni