bpo-29613: Added support for SameSite cookies #6413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And suggestions by members.
timgraham
reviewed
Apr 7, 2018
Doc/library/http.cookies.rst
Outdated
| @@ -153,6 +159,9 @@ Morsel Objects | |||
| :attr:`~Morsel.coded_value` are read-only. Use :meth:`~Morsel.set` for | |||
| setting them. | |||
|
|
|||
| .. versionchanged:: 3.8 | |||
| Added support for :attr:`samesite` attribute. | |||
Doc/library/http.cookies.rst
Outdated
|
|
||
| The attribute :attr:`httponly` specifies that the cookie is only transferred | ||
| in HTTP requests, and is not accessible through JavaScript. This is intended | ||
| to mitigate some forms of cross-site scripting. | ||
|
|
||
| The attribute :attr:`samesite` specifies that browser is not allowed to send the |
Doc/library/http.cookies.rst
Outdated
|
|
||
| The attribute :attr:`httponly` specifies that the cookie is only transferred | ||
| in HTTP requests, and is not accessible through JavaScript. This is intended | ||
| to mitigate some forms of cross-site scripting. | ||
|
|
||
| The attribute :attr:`samesite` specifies that browser is not allowed to send the | ||
| cookie along with cross-site requests. This help to mitigate CSRF attacks. Valid |
Lib/test/test_http_cookies.py
Outdated
| @@ -121,6 +121,19 @@ def test_set_secure_httponly_attrs(self): | |||
| self.assertEqual(C.output(), | |||
| 'Set-Cookie: Customer="WILE_E_COYOTE"; HttpOnly; Secure') | |||
|
|
|||
| def test_samesite_attrs(self): | |||
| samesite_values = ['Strict', 'Lax'] | |||
There was a problem hiding this comment.
Might add tests for 'strict' and 'lax' as the values are case-insensitive from what I read.
|
Thanks! Feedback addressed |
dstufft
approved these changes
Apr 7, 2018
|
@akash0x53 I would encourage you to apply for a Google Patch Reward for your work on this: https://www.google.com/about/appsecurity/patch-rewards/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #214.
Closes #214
https://bugs.python.org/issue29613