Skip to content

bpo-33485: make autoconf behave correctly in more cases #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpo-33485: make autoconf behave correctly in more cases #6782

wants to merge 2 commits into from

Conversation

grimreaper
Copy link
Contributor

@grimreaper grimreaper commented May 13, 2018 •
edited by bedevere-bot
Loading

@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch from 208a791 to f3d7973 Compare May 13, 2018 19:06
@grimreaper grimreaper mentioned this pull request May 13, 2018
Closed
@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch 5 times, most recently from 3529454 to b192b1a Compare May 19, 2018 00:22
@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch 2 times, most recently from 36b2aea to bde3063 Compare May 25, 2018 14:19
@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch from bde3063 to 718104b Compare June 9, 2018 17:46
@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch 2 times, most recently from 17078cb to 960a617 Compare June 29, 2018 14:32
@grimreaper grimreaper force-pushed the eax/build/autoconf_target branch from 960a617 to 92b321c Compare July 28, 2018 07:42
@csabella csabella requested review from doko42 and vstinner May 20, 2019 21:02
MaxwellDupre
MaxwellDupre approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the confg.log:
config.status:1311: creating pyconfig.h
config.status:1492: pyconfig.h is unchanged
Not sure if --force flag works here but not doing any harm.
Also test results:
Test suite interrupted by signal SIGINT.
1 test omitted:
test_poplib (obvious bug but unrelated)
400 tests OK.
Noted Debian has switched to autoreconf because of autoconf bugs. Also, this looks more efficient and one level up cant be bad.

However, the NEWS entry could be better - more in line with PR title and/or bug report.

@vstinner
Copy link
Member

cc @tiran @erlend-aasland

@tiran
Copy link
Member

tiran commented May 29, 2022

The rule now uses autoreconf with force and error:

.PHONY: autoconf
autoconf:
        (cd $(srcdir); autoreconf -ivf -Werror)

@tiran tiran closed this May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@doko42 doko42 Awaiting requested review from doko42

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grimreaper @vstinner @tiran @MaxwellDupre @the-knights-who-say-ni @bedevere-bot