Skip to content

bpo-5945: Improve mappings and sequences C API docs. #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

bpo-5945: Improve mappings and sequences C API docs. #7029

merged 1 commit into from
May 22, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 21, 2018 •
edited by bedevere-bot
Loading

This fixes bpo-5945, but may also have relations to other open documentation issues.

https://bugs.python.org/issue5945

willingc
willingc approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serhiy-storchaka for these clear and helpful doc changes

@serhiy-storchaka serhiy-storchaka merged commit f5b1183 into python:master May 22, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2018
@serhiy-storchaka @miss-islington
bpo-5945: Improve mappings and sequences C API docs. (pythonGH-7029)
6379a97 
(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-7045 is a backport of this pull request to the 3.7 branch.

@serhiy-storchaka
Copy link
Member Author

Thanks @willingc for your review.

@serhiy-storchaka serhiy-storchaka deleted the map-seq-c-api-docs branch May 22, 2018 08:03
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f5b1183610d5888db3bbd639b1a0c945dbd8f8dd 3.6

miss-islington added a commit that referenced this pull request May 22, 2018
@miss-islington @serhiy-storchaka
bpo-5945: Improve mappings and sequences C API docs. (GH-7029)
e1a78ca 
(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.6] bpo-5945: Improve mappings and sequences C API docs. (pythonGH-…
7665cf5 
…7029).

(cherry picked from commit f5b1183)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-7049 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request May 22, 2018
@serhiy-storchaka
[3.6] bpo-5945: Improve mappings and sequences C API docs. (GH-7029). (…
93e9fb5 
…GH-7049)

(cherry picked from commit f5b1183)
@ilevkivskyi ilevkivskyi mentioned this pull request Jun 4, 2018
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@vadmium vadmium Awaiting requested review from vadmium

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @willingc @the-knights-who-say-ni