Skip to content

bpo-33628: IDLE: Minor code cleanup on codecontext #7085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2018
Merged

bpo-33628: IDLE: Minor code cleanup on codecontext #7085

merged 3 commits into from
May 24, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented May 23, 2018 •
edited by bedevere-bot
Loading

@csabella csabella requested a review from terryjreedy as a code owner May 23, 2018 23:54
@terryjreedy terryjreedy self-assigned this May 24, 2018
@terryjreedy terryjreedy added needs backport to 3.6 tests Tests in the Lib/test dir labels May 24, 2018
terryjreedy
terryjreedy approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are the few minor changes I pushed. I intend to merge when retest passes.

@terryjreedy terryjreedy merged commit 8506016 into python:master May 24, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2018
@csabella @miss-islington
bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (p…
b0f334f 
…ythonGH-7085)

(cherry picked from commit 8506016)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

GH-7091 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2018
@csabella @miss-islington
bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (p…
0b1dcd8 
…ythonGH-7085)

(cherry picked from commit 8506016)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

GH-7092 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 24, 2018
@miss-islington @csabella
bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (G…
935c81b 
…H-7085)

(cherry picked from commit 8506016)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request May 24, 2018
@miss-islington @csabella
bpo-33628: IDLE: Minor code cleanup of codecontext.py and its tests (G…
b2ab5dc 
…H-7085)

(cherry picked from commit 8506016)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the context branch May 24, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni