bpo-29116: Fix error messages for concatenating bytes and bytearray w… #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith unsupported type.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @loewis and @benjaminp to be potential reviewers. |
zhangyangyu
approved these changes
Mar 18, 2017
ilevkivskyi
reviewed
Mar 18, 2017
| @@ -1438,7 +1438,7 @@ bytes_concat(PyObject *a, PyObject *b) | |||
| if (PyObject_GetBuffer(a, &va, PyBUF_SIMPLE) != 0 || | |||
| PyObject_GetBuffer(b, &vb, PyBUF_SIMPLE) != 0) { | |||
| PyErr_Format(PyExc_TypeError, "can't concat %.100s to %.100s", | |||
| Py_TYPE(a)->tp_name, Py_TYPE(b)->tp_name); | |||
| Py_TYPE(b)->tp_name, Py_TYPE(a)->tp_name); | |||
There was a problem hiding this comment.
I think it would be clearer to use "concatenate" instead of "concat" here and above. (Also other errors of similar kind use the full word.)
There was a problem hiding this comment.
I'll do this in separate PR, because this is larger change that shouldn't be backported. The same error message is generated in yet one place (with correct order of arguments). Maybe will make the message being more similar to other concatenate messages.
ilevkivskyi
approved these changes
Mar 19, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 19, 2017
…ith unsupported type. (python#709) (cherry picked from commit 6b5a9ec)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 19, 2017
…ith unsupported type. (python#709) (cherry picked from commit 6b5a9ec)
This was referenced Mar 19, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 19, 2017
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith unsupported type.