bpo-32458: Increase TLS timeout in test_asyncio #7157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_asyncio: Increase test_start_tls_server_1() client timeout from 5 seconds to 60 seconds, and server timeout from 10 to 120 seconds. The timeout is only used to check if the test hangs, but the 5 seconds limit is commonly reached on slow CIs like Travis CI and some buildbots.
|
I tested manually my PR on my laptop and I failed to make the test fail again. I opened 4 terminals to run commands in parallel: (1) ./python -m test test_asyncio -m test_start_tls_server_1 -F The system load was larger than 42. |
|
Oh, the PR #5054 disabled SSL tests on the proactor event loop: my PR now also reenables these tests. Let's see if test_asyncio of my PR pass on AppVeyor ;-) |
|
Sorry, need to close this as it's in direct conflict with #7130 that I'm about to merge :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.
The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.
https://bugs.python.org/issue32458