Skip to content

gh-75128: Fix create_server to handle the case when iface isn't IPv6 enabled. #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-75128: Fix create_server to handle the case when iface isn't IPv6 enabled. #7207

wants to merge 1 commit into from
+18 −3

Conversation

1st1
Copy link
Member

@1st1 1st1 commented May 29, 2018 •
edited by bedevere-app bot
Loading

@1st1 1st1 requested a review from pitrou May 29, 2018 15:40
@1st1 1st1 requested a review from asvetlov as a code owner May 29, 2018 15:40
@1st1 1st1 changed the title bpo-30945: Fix create_server to handle the case when iface isn't IPv6… bpo-30945: Fix create_server to handle the case when iface isn't IPv6 enabled. May 29, 2018
@1st1
Copy link
Member Author

1st1 commented May 29, 2018

Not sure how to test this though.

@1st1
Copy link
Member Author

1st1 commented May 29, 2018

@pitrou Could you please take a look? Alternatively I can close this PR and you can submit a new one (the patch is yours :))

pitrou
pitrou approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't think there's an easy way to test this, apart perhaps through mocking.

@1st1
Copy link
Member Author

1st1 commented May 29, 2018

Looks good to me. I don't think there's an easy way to test this, apart perhaps through mocking.

Thanks. I'll think about adding a mocking test. This won't be merged till after 3.7.0 though.

asvetlov
asvetlov approved these changes May 29, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cecton cecton mannequin mentioned this pull request Apr 10, 2022
Closed
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 21, 2024
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 15, 2024
@picnixz picnixz changed the title bpo-30945: Fix create_server to handle the case when iface isn't IPv6 enabled. gh-75128: Fix create_server to handle the case when iface isn't IPv6 enabled. Dec 15, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 27, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@1st1 @asvetlov @pitrou @iritkatriel @the-knights-who-say-ni @ezio-melotti @bedevere-bot