Skip to content

bpo-33699: Describe try's else clause with the rest of the try clause #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2018
Merged

bpo-33699: Describe try's else clause with the rest of the try clause #7252

merged 3 commits into from
Nov 11, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented May 30, 2018 •
edited by bedevere-bot
Loading

taleinat
taleinat reviewed Jun 12, 2018
View reviewed changes
@taleinat
Copy link
Contributor

IMO this is an improvement, but I'll let someone who has worked on the documentation more make this call.

@vstinner
Copy link
Member

cc @1st1 @pablogsal

pablogsal
pablogsal reviewed Oct 20, 2018
View reviewed changes
pablogsal
pablogsal approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for the quick response! :)

@serhiy-storchaka serhiy-storchaka added the docs Documentation in the Doc dir label Nov 7, 2018
@andresdelfino
Copy link
Contributor Author

Don't know a way to get the CI run again so all checks are successful :/

@Mariatta
Copy link
Member

I restarted it

@miss-islington
Copy link
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit b086c8a into python:master Nov 11, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10467 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2018
@andresdelfino @miss-islington
bpo-33699: Describe try's else clause with the rest of the try clause (…
0928e04 
…pythonGH-7252)

https://bugs.python.org/issue33699
(cherry picked from commit b086c8a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-10468 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @andresdelfino, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b086c8afdb8c862011e3e27d4c8f6833749f2c56 2.7

@miss-islington miss-islington self-assigned this Nov 11, 2018
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2018
@andresdelfino @miss-islington
bpo-33699: Describe try's else clause with the rest of the try clause (…
8420501 
…pythonGH-7252)

https://bugs.python.org/issue33699
(cherry picked from commit b086c8a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the try-else branch November 11, 2018 19:35
@andresdelfino
Copy link
Contributor Author

I restarted it

Thank you :)

miss-islington added a commit that referenced this pull request Nov 11, 2018
@miss-islington @andresdelfino
bpo-33699: Describe try's else clause with the rest of the try clause (…
7d7ff67 
…GH-7252)

https://bugs.python.org/issue33699
(cherry picked from commit b086c8a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
miss-islington added a commit that referenced this pull request Nov 11, 2018
@miss-islington @andresdelfino
bpo-33699: Describe try's else clause with the rest of the try clause (…
3f6a0a2 
…GH-7252)

https://bugs.python.org/issue33699
(cherry picked from commit b086c8a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-10469 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit that referenced this pull request Nov 11, 2018
@andresdelfino @miss-islington
[2.7] bpo-33699: Describe try's else clause with the rest of the try …
fb8eb2c 
…clause (GH-7252) (GH-10469)

https://bugs.python.org/issue33699
(cherry picked from commit b086c8a)



https://bugs.python.org/issue33699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@Mariatta Mariatta Mariatta approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@andresdelfino @taleinat @vstinner @Mariatta @miss-islington @bedevere-bot @pablogsal @serhiy-storchaka @the-knights-who-say-ni