bpo-33664: Scroll IDLE editor text by lines #7351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryjreedy
approved these changes
Jun 3, 2018
|
Yes, I did the wheel first and was really happy with the way it worked. As I think you said in one of the messages, it was mildly annoying; but now with the fix, I think it may have been more than mild. :-) |
|
I agree. The part-line annoyance, though mild per movement, is repeated over and over. This page, with multiple fonts, symbols, and widgets, appears to always move by pixels, even for click on the scrollbar buttons and trough. Notepad++, with 1 font, moves by lines, like after this patch. |
|
AppVeyor is down, so merging will have to wait. Too bad. |
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2018
Previously, the mouse wheel and scrollbar slider moved text by a fixed number of pixels, resulting in partial lines at the top of the editor box. The change also applies to the shell and grep output windows, but not to read-only text views. (cherry picked from commit d49dbd9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
|
GH-7397 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2018
Previously, the mouse wheel and scrollbar slider moved text by a fixed number of pixels, resulting in partial lines at the top of the editor box. The change also applies to the shell and grep output windows, but not to read-only text views. (cherry picked from commit d49dbd9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
|
GH-7398 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 4, 2018
Previously, the mouse wheel and scrollbar slider moved text by a fixed number of pixels, resulting in partial lines at the top of the editor box. The change also applies to the shell and grep output windows, but not to read-only text views. (cherry picked from commit d49dbd9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Jun 4, 2018
Previously, the mouse wheel and scrollbar slider moved text by a fixed number of pixels, resulting in partial lines at the top of the editor box. The change also applies to the shell and grep output windows, but not to read-only text views. (cherry picked from commit d49dbd9) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the mouse wheel and scrollbar slider moved text by a fixed
number of pixels, resulting in partial lines at the top of the editor
box. The change also applies to the shell and grep output windows,
but not to read-only text views.
https://bugs.python.org/issue33664