Skip to content

bpo-33798: Fix csv module comment regarding dict insertion order #7490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2018
Merged

bpo-33798: Fix csv module comment regarding dict insertion order #7490

merged 2 commits into from
Jun 8, 2018

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Jun 7, 2018 •
edited by bedevere-bot
Loading

@methane methane added docs Documentation in the Doc dir skip news needs backport to 3.7 labels Jun 8, 2018
@methane
Copy link
Member

methane commented Jun 8, 2018 •
edited
Loading

I feel this change is bit redundant.
Even though dict preserves insertion order, what should we do when first row and second row have different order? Or what should DictWriter.writeheader() write?

I think just removing last "Since Python's ~" paragraph is enough.

@andresdelfino
Copy link
Contributor Author

Yes, I agree. I'll update the PR in a few minutes.

Thanks for fhe review :)

@methane methane merged commit 6860629 into python:master Jun 8, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 8, 2018
@andresdelfino @miss-islington
bpo-33798: Update csv document about dict order (pythonGH-7490)
40a1a20 
(cherry picked from commit 6860629)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-7531 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jun 8, 2018
@miss-islington @andresdelfino
bpo-33798: Update csv document about dict order (GH-7490)
9f56a93 
(cherry picked from commit 6860629)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the csv-dict-order branch June 8, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andresdelfino @methane @miss-islington @bedevere-bot @the-knights-who-say-ni