Skip to content

bpo-33878: Doc: Fix missing case by simplifying. #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jun 17, 2018

The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.

https://bugs.python.org/issue33878

The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
@vstinner
Copy link
Member

cc @pablogsal

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplified version. As a side note, I would say that a lot of people find surprising derivatives of

[] = []

Although this is covered in The object must be iterable with the same number of terms as there are targets in the target list maybe it would be useful to explicitly list that case.

@matrixise
Copy link
Member

@JulienPalard ?

@JulienPalard
Copy link
Member Author

@pablogsal thanks for the review, something like:

The object must be iterable with the same number (zero included) of terms as there are targets in the target list

? I'm not a huge fan of explicitly listing this already covered case, the sentences are already complicated, do you think it's worth it?

@pablogsal
Copy link
Member

pablogsal commented Nov 7, 2018

do you think it's worth it?

@JulienPalard Probably not, let's keep this simple as you suggest :)

@srinivasreddy
Copy link
Contributor

ping to remind that @gvanrossum wanted this PR to be merged.

@gvanrossum
Copy link
Member

Whoa, my desire was for (a) = 42 to be disallowed by the interpreter. I leave the docs up to the experts.

@JulienPalard JulienPalard merged commit 082875d into python:master Nov 11, 2018
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-10472 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 11, 2018
The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
(cherry picked from commit 082875d)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link

GH-10473 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2018
The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
(cherry picked from commit 082875d)

Co-authored-by: Julien Palard <julien@palard.fr>
JulienPalard added a commit that referenced this pull request Nov 12, 2018
The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
(cherry picked from commit 082875d)

Co-authored-by: Julien Palard <julien@palard.fr>
JulienPalard added a commit that referenced this pull request Nov 12, 2018
The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
(cherry picked from commit 082875d)

Co-authored-by: Julien Palard <julien@palard.fr>
@JulienPalard JulienPalard deleted the doc.reference.simple_stmts branch June 16, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants