Skip to content

bpo-20906: Various revisions to the Unicode howto #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

akuchling
Copy link
Contributor

@akuchling akuchling commented Jul 22, 2018

  • Removes the no-longer-necessary historical notes.
  • Extensively edits the definition section in attempt to make it more correct
  • Add sections on casefold() and normalize()

Open issue: is it OK to just include Unicode characters in .rst files?

https://bugs.python.org/issue20906

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Jul 22, 2018
@akuchling akuchling force-pushed the unicode-howto-update branch from 8fc0659 to 2e79661 Compare July 22, 2018 14:59
@serhiy-storchaka
Copy link
Member

Open issue: is it OK to just include Unicode characters in .rst files?

Try to build PDF. Not all Unicode characters are supported by TeX.

@akuchling
Copy link
Contributor Author

Rebased against the current master, so this would be ready for review or merging.

@akuchling akuchling force-pushed the unicode-howto-update branch from e44a86e to ec30ea1 Compare March 2, 2019 21:40
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added just few minor comments.

print('length of second string=', len(multiple_chars))
print(compare_strs(single_char, multiple_chars))

When run, this outputs::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the special code-block type for highlighting.

When run, this outputs:

.. code-block:: shell-session

   $ python3 compare-strs.py

length of second string= 2
True

The first argument to the :func:`~unicodedata.normalize` function is a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The first argument to the :func:`~unicodedata.normalize` function is a
The first argument to the :func:`~unicodedata.normalize` function is a

@akuchling akuchling force-pushed the unicode-howto-update branch from ec30ea1 to 9f5d85d Compare March 4, 2019 03:04
@akuchling akuchling merged commit 97c288d into python:master Mar 4, 2019
@bedevere-bot
Copy link

@akuchling: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @akuchling for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2019
* bpo-20906: Corrections & revisions to Unicode HOWTO

* bpo-34484: don't describe range as a Private Use Area
(cherry picked from commit 97c288d)

Co-authored-by: Andrew Kuchling <amk@amk.ca>
@bedevere-bot
Copy link

GH-12155 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 4, 2019
* bpo-20906: Corrections & revisions to Unicode HOWTO

* bpo-34484: don't describe range as a Private Use Area
(cherry picked from commit 97c288d)

Co-authored-by: Andrew Kuchling <amk@amk.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants