Skip to content

bpo-34272: Reorganize C API tests. #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 29, 2018

Move most some C API tests into Lib/test/test_capi/.

https://bugs.python.org/issue34272

@arhadthedev
Copy link
Member

Is the idea to group C API tests still feasible? It would be great to immediately see from a file structure that test_getargs2.py and test_structmembers.py are not about Python libraries or their module backends.

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts need to be resolved.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
Member Author

Thank you for a reminder. I completely forget about this simple PR.

@serhiy-storchaka serhiy-storchaka merged commit f883b7f into python:main Nov 10, 2022
@serhiy-storchaka serhiy-storchaka deleted the test_capi branch November 10, 2022 06:54
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 10, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-99314 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-99315 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 10, 2022
miss-islington added a commit that referenced this pull request Nov 12, 2022
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Nov 12, 2022
Move some C API tests into Lib/test/test_capi/.
(cherry picked from commit f883b7f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ethanfurman pushed a commit to ethanfurman/cpython that referenced this pull request Nov 12, 2022
Move some C API tests into Lib/test/test_capi/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants