bpo-34503: Fix refleak in PyErr_SetObject() #8934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izbyshev
commented
Aug 25, 2018
Python/errors.c
Outdated
| @@ -98,7 +98,6 @@ PyErr_SetObject(PyObject *exception, PyObject *value) | |||
| exc_value = _PyErr_GetTopmostException(tstate)->exc_value; | |||
| if (exc_value != NULL && exc_value != Py_None) { | |||
| /* Implicit exception chaining */ | |||
| Py_INCREF(exc_value); | |||
There was a problem hiding this comment.
Not sure whether exc_value may somehow be freed as the result of calling arbitrary Python code below. Maybe it's safer to preserve this Py_INCREF and insert Py_DECREF into the right place instead?
There was a problem hiding this comment.
Yes, it is safer to preserve this Py_INCREF.
There was a problem hiding this comment.
Thank you, I've updated the PR.
zhangyangyu
approved these changes
Aug 26, 2018
serhiy-storchaka
approved these changes
Aug 26, 2018
|
Thanks @izbyshev for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8943 is a backport of this pull request to the 3.7 branch. |
|
GH-8944 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2018
(cherry picked from commit a2eefa6) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 26, 2018
(cherry picked from commit a2eefa6) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
miss-islington
added a commit
that referenced
this pull request
Aug 26, 2018
miss-islington
added a commit
that referenced
this pull request
Aug 26, 2018
CuriousLearner
added a commit
to CuriousLearner/cpython
that referenced
this pull request
Aug 27, 2018
* master: (104 commits) Fast path for exact floats in math.hypot() and math.dist() (pythonGH-8949) Remove AIX workaround test_subprocess (pythonGH-8939) bpo-34503: Fix refleak in PyErr_SetObject() (pythonGH-8934) closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (pythonGH-8935) closes bpo-34501: PyType_FromSpecWithBases: Check spec->name before dereferencing it. (pythonGH-8930) closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (pythonGH-8928) Remove unneeded PyErr_Clear() in _winapi_SetNamedPipeHandleState_impl() (pythonGH-8281) Fix markup in stdtypes documentation (pythonGH-8905) bpo-34395: Don't free allocated memory on realloc fail in load_mark() in _pickle.c. (pythonGH-8788) Fix upsizing of marks stack in pickle module. (pythonGH-8860) bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (pythonGH-8841) closes bpo-34493: Objects/genobject.c: Add missing NULL check to compute_cr_origin() (pythonGH-8911) Fixed typo with asynccontextmanager code example (pythonGH-8845) bpo-34426: fix typo (__lltrace__ -> __ltrace__) (pythonGH-8822) bpo-13312: Avoid int underflow in time year. (pythonGH-8912) bpo-34492: Python/coreconfig.c: Fix _Py_wstrlist_copy() (pythonGH-8910) bpo-34448: Improve output of usable wchar_t check (pythonGH-8846) closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (pythonGH-8869) bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (pythonGH-8864) Fix typo in the dataclasses's doc (pythonGH-8896) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34503