Skip to content

Fix "Python" casing in a few places #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2018
Merged

Fix "Python" casing in a few places #9001

merged 4 commits into from
Sep 14, 2018

Conversation

andresdelfino
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Aug 29, 2018
@andresdelfino andresdelfino changed the title Fix Python casing in a few places Fix "Python" casing in a few places Aug 29, 2018
@andresdelfino andresdelfino requested a review from a team as a code owner August 29, 2018 21:35
@serhiy-storchaka serhiy-storchaka removed the request for review from a team August 30, 2018 15:47
@serhiy-storchaka
Copy link
Member

LGTM. Are there cases in comments and docstrings? Changes in docstrings or printed messages can break third-party tests, so they should be made in a separate issue and merged only into master.

It may be worth to open an issue on the tracker for attracting attention of other possible reviewers.

serhiy-storchaka
serhiy-storchaka reviewed Aug 30, 2018
View reviewed changes
Doc/library/zipapp.rst
@@ -1,8 +1,8 @@
:mod:`zipapp` --- Manage executable python zip archives
:mod:`zipapp` --- Manage executable Python zip archives
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth to write zip as ZIP if it means the file format. This spelling is used in the zipfile documentation and some other places. But this is a separate issue or PR.

@serhiy-storchaka
Copy link
Member

Other names that could be unified: Windows, macOS (the current official name for Mac OS X and OS X), POSIX, Unix or UNIX (?), Tcl/Tk, IDLE.

@andresdelfino
Copy link
Contributor Author

@serhiy-storchaka This PR does not modify docstrings nor comments. I didn't search in the source code. Personally, I don't see the point of opening PRs for fixing this kind of mistakes in the source code if they don't show up to the end user.

Were you suggesting to open an issue if the PR modified docstrings/comments only, or do you think it makes sense to open one when the PR only changes the documentation?

Should the fixes for Windows/macOS/POSIX/Unix (according to Documenting Python)/Tcl/Tk/IDLE be included in this PR, should they share a new PR, or should they have a PR for each name?

@encukou
Copy link
Member

encukou commented Sep 14, 2018

Should the fixes for Windows/macOS/POSIX/Unix (according to Documenting Python)/Tcl/Tk/IDLE be included in this PR, should they share a new PR, or should they have a PR for each name?

They can share a new PR.

If you do changes for things that aren't yet covered in Documenting Python, consider also opening a PR for the devguide, so the proper capitalization is recorded there.

@encukou encukou merged commit 271818f into python:master Sep 14, 2018
@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2018
@andresdelfino @miss-islington
Fix "Python" casing in a few places (pythonGH-9001)
fda5b5d 
(cherry picked from commit 271818f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@bedevere-bot
Copy link

GH-9313 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @andresdelfino and @encukou, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 271818fe279df5ab292789f97c3a52c477bd8f13 3.6

@miss-islington
Copy link
Contributor

Sorry, @andresdelfino and @encukou, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 271818fe279df5ab292789f97c3a52c477bd8f13 2.7

@encukou
Copy link
Member

encukou commented Sep 14, 2018

I'm OK with this not being backported to 3.6 and below, but cherry_pick if you disagree.

@andresdelfino andresdelfino deleted the use-proper-python-casing branch September 14, 2018 17:26
@andresdelfino
Copy link
Contributor Author

I agree with you.

encukou pushed a commit that referenced this pull request Sep 14, 2018
@miss-islington @andresdelfino @encukou
Fix "Python" casing in a few places (GH-9001) (GH-9313)
b2ecb8b 
(cherry picked from commit 271818f)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@encukou encukou

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andresdelfino @serhiy-storchaka @encukou @miss-islington @bedevere-bot @the-knights-who-say-ni