Skip to content

[2.7] bpo-32502: Discard 64-bit (and other invalid) hardware addresses (GH-5254). #9125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

[2.7] bpo-32502: Discard 64-bit (and other invalid) hardware addresses (GH-5254). #9125

merged 1 commit into from
Sep 11, 2018

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Sep 9, 2018 •
edited by bedevere-bot
Loading

(cherry picked from commit 6b273f7)

Co-authored-by: Bo Bayles bbayles@gmail.com

https://bugs.python.org/issue32502

yan12125 referenced this pull request Sep 9, 2018
@bbayles @warsaw
bpo-32502: Discard 64-bit (and other invalid) hardware addresses (#5254)
6b273f7
@yan12125 yan12125 mentioned this pull request Sep 9, 2018
Merged
11 tasks
@bbayles @yan12125
[2.7] bpo-32502: Discard 64-bit (and other invalid) hardware addresses (
3ac3478 
GH-5254).

(cherry picked from commit 6b273f7)

Co-authored-by: Bo Bayles <bbayles@gmail.com>
yan12125
yan12125 commented Sep 9, 2018
View reviewed changes
Lib/test/test_uuid.py
finally:
uuid._node = uuid_real__node
uuid._NODE_GETTERS_WIN32 = uuid_real__NODE_GETTERS_WIN32
uuid._NODE_GETTERS_UNIX = uuid_real__NODE_GETTERS_UNIX
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a better way when unittest.mock is missing from Python 2.7

@gpshead gpshead requested a review from benjaminp September 11, 2018 20:38
@benjaminp benjaminp merged commit d919c60 into python:2.7 Sep 11, 2018
@yan12125 yan12125 deleted the backport-6b273f7-2.7 branch September 12, 2018 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yan12125 @benjaminp @the-knights-who-say-ni @bedevere-bot @bbayles