gh-74166: make all_errors keyword-only #91704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
commented
Apr 19, 2022
| @@ -806,7 +806,7 @@ def getfqdn(name=''): | |||
| _GLOBAL_DEFAULT_TIMEOUT = object() | |||
|
|
|||
| def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT, | |||
| source_address=None, all_errors=False): | |||
| source_address=None, *, all_errors=False): | |||
There was a problem hiding this comment.
Is it weird that all_errors is kw-only and the others are not?
There was a problem hiding this comment.
Nope. It's called "legacy" :-)
vstinner
approved these changes
Apr 19, 2022
| @@ -806,7 +806,7 @@ def getfqdn(name=''): | |||
| _GLOBAL_DEFAULT_TIMEOUT = object() | |||
|
|
|||
| def create_connection(address, timeout=_GLOBAL_DEFAULT_TIMEOUT, | |||
| source_address=None, all_errors=False): | |||
| source_address=None, *, all_errors=False): | |||
There was a problem hiding this comment.
Nope. It's called "legacy" :-)
|
Thanks. Once I wanted to convert most open() parameter to keyword-only. I never recall what are positional parameter after the first two obvious arguments. But my idea got quickly rejected. "The ship has sailed", it's too late to convert positional-or-keyword parameter to keyword-only, at least without a slow deprecation process. But for new parameter, we have a great freedom to decide how to declare them! Keyword only, positional only, etc. |
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
Apr 26, 2022
AlexWaygood
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.