Skip to content

gh-91603: Speed up UnionType instantiation #91865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

gh-91603: Speed up UnionType instantiation #91865

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1d5de83
Speed up UnionType instantiation
uriyyo Apr 23, 2022
ac2b3a0
Don't use list
uriyyo Apr 23, 2022
b8f9eae
Fix issue with uncopied data
uriyyo Apr 23, 2022
d3dba88
Remove deduplication and flatting
uriyyo Apr 24, 2022
3ac3013
Return assert
uriyyo Apr 24, 2022
7e87ef0
Minor fixes
uriyyo Apr 24, 2022
fde9507
Fix issue
uriyyo Apr 24, 2022
bc348c9
Update Objects/unionobject.c
uriyyo Apr 25, 2022
fbc7934
Update Objects/unionobject.c
uriyyo Apr 25, 2022
4321116
Update Objects/unionobject.c
uriyyo Apr 25, 2022
f1e06da
Fix formatting
uriyyo Apr 25, 2022
70d9d30
Update Objects/unionobject.c
uriyyo Apr 26, 2022
e928a6c
Update Objects/unionobject.c
uriyyo Apr 26, 2022
8c3e307
Update Objects/unionobject.c
uriyyo Apr 26, 2022
97b2944
Fix formatting
uriyyo Apr 26, 2022
6b8e2e7
Refactor merge functions
uriyyo Apr 26, 2022
eb784c4
Fix formatting
uriyyo Apr 26, 2022
c82eca6
Remove Py_DECREF after resize failed
uriyyo Apr 26, 2022
0cef035
Minor fixes
uriyyo Apr 26, 2022
c361b10
Merge remote-tracking branch 'fork/main' into feature/faster-union-in…
uriyyo Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/unionobject.c 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
@uriyyo @serhiy-storchaka
uriyyo and serhiy-storchaka authored Apr 26, 2022
commit 70d9d3053ef3a49089b315bc2bc515880227c0a2
2 changes: 1 addition & 1 deletion Objects/unionobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ merge_obj_and_union(PyObject *left, PyObject *right) {
}
}

if(_PyTuple_Resize(&tuple, pos) < 0) {
if (_PyTuple_Resize(&tuple, pos) < 0) {
Py_DECREF(tuple);
return NULL;
}
Expand Down