Skip to content

gh-89301: Fix regression with bound values in traced SQLite statements #92053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2022
Merged

gh-89301: Fix regression with bound values in traced SQLite statements #92053

merged 3 commits into from
May 2, 2022
+104 −15

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 29, 2022 •
edited
Loading

Resolves gh-89301

@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 29, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ab35f4b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@erlend-aasland
Make exception string greppable
4e9ef10
@erlend-aasland
Simplify test
e58797c 
SQLite seems to have slightly inconsisten behaviour when it comes to
enforcing limits. It might have something to do with the SQLite compile
time options, or it may be a bug. Simplifying the test seems to work
in different environments.
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e58797c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@erlend-aasland erlend-aasland marked this pull request as ready for review May 2, 2022 13:34
@erlend-aasland erlend-aasland requested review from JelleZijlstra and removed request for berkerpeksag May 2, 2022 13:34
@erlend-aasland
Copy link
Contributor Author

FYI, AMD64 Fedora Stable Refleaks PR failed test_embed, so that looks unrelated.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2022 •
edited
Loading

FTR, this is pretty much the same as GH-28240, but with better tests and a more accurate NEWS entry.

@JelleZijlstra JelleZijlstra merged commit 721aa96 into python:main May 2, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 721aa96540bb96700f8c4bab0b4095b43491dca1 3.10

@erlend-aasland erlend-aasland deleted the sqlite-fix-trace branch May 2, 2022 14:15
@erlend-aasland
Copy link
Contributor Author

Thanks, I'll fix the backport.

@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlite3 regression: bound values are not expanded in traced statements
5 participants
@erlend-aasland @bedevere-bot @miss-islington @JelleZijlstra @ZeroIntensity