Skip to content

[3.10] gh-89301: Fix regression with bound values in traced SQLite statements #92147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

(cherry picked from commit 721aa96)

@erlend-aasland
Copy link
Contributor Author

FTR, the 3.10 sqlite3 test suite lack a lot (all?) of the helper methods that are present in 3.11. We could backport all those, but in the past, we've just removed the tests that were not applicable due to this limitation. I'm not sure backporting the test helpers are worth it; OTOH, its not a big deal to backport them.

@JelleZijlstra
Copy link
Member

FTR, the 3.10 sqlite3 test suite lack a lot (all?) of the helper methods that are present in 3.11. We could backport all those, but in the past, we've just removed the tests that were not applicable due to this limitation. I'm not sure backporting the test helpers are worth it; OTOH, its not a big deal to backport them.

Thanks for the explanation! I think it's helpful to keep test helpers as much as possible the same across branches, so all the branches are well-tested and backports are easy. But we don't have to do that right now.

@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
@JelleZijlstra JelleZijlstra merged commit 178d79a into python:3.10 May 2, 2022
@erlend-aasland erlend-aasland deleted the backport-sqlite-fix-trace-3.10 branch May 2, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants