gh-67248: Update cmd.py #92254
Merged
gh-67248: Update cmd.py #92254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sort the miscellaneous topics
|
All commit authors signed the Contributor License Agreement. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
Looks reasonable! It looks like there are tests for some of this in https://github.com/python/cpython/blob/main/Lib/test/test_cmd.py -- might make sense to add a test that reflects this behavior change? I talked to @ericsnowcurrently here at the PyCon sprint about fixing the issue in |
rename 'help' to 'topics', change it from a dict to a set
Add tests for miscellaneous help topics
|
@carljm I've added terryjreedy's suggestions from the issue comments. OTOH, I've only added one misc topic, I guess I need to think of another to test sorting. |
add a second misc topic to test sorting also, the empty command tested with mycmd.cmdloop() was repeating a command issued with mycmd.onecmd(), so I moved it into the middle of the list of commands, to make the output more dependable.
JelleZijlstra
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort the miscellaneous topics, per #67248