gh-92391: Add __class_getitem__ to csv.DictReader and csv.DictWriter #92393
Conversation
There was a problem hiding this comment.
This makes sense to me.
I'm not 100% confident that the stubs for these classes in typeshed are "stable" -- I'm slightly nervous that we'll continue to fiddle with the stubs for these classes in typeshed. More detailed thoughts here: python/typeshed#7787 (comment).
However, I am fairly confident that these classes will continue to be generic in typeshed, even if we do make other changes to the stubs. And that's the only thing that's relevant to whether __class_getitem__ should be added to the classes.
|
I believe we may have just missed the 3.11 feature freeze, however. So I guess we'll have to wait for 3.12 :) |
|
I see the Azure Pipelines failure is a docs failure relating to "What's New in 3.11", which you haven't changed in this PR 🙃 |
|
Yeah we missed 3.11 by around an hour. Bummer :(. |
|
Merged |
|
First new feature for 3.12! |
Nice! Also my first CPython PR 😄 |
Congrats! :D |
|
This change isn't noted in the documentation for |
Closes #92391