[3.11] gh-92550 - Fix regression in pathlib.Path.rglob() (GH-92583)
#92589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2583) We could try to remedy this by taking a slice, but we then run into an issue where the empty string will match altsep on POSIX. That rabbit hole could keep getting deeper. A proper fix for the original issue involves making pathlib's path normalisation more configurable - in this case we want to retain trailing slashes, but in other we might want to preserve `./` prefixes, or elide `../` segments when we're sure we won't encounter symlinks. This reverts commit ea2f5bc. (cherry picked from commit dcdf250) Co-authored-by: Barney Gale <barney.gale@gmail.com>
|
@barneygale: Status check is done, and it's a success ✅ . |
2 similar comments
|
@barneygale: Status check is done, and it's a success ✅ . |
|
@barneygale: Status check is done, and it's a success ✅ . |
brettcannon
approved these changes
May 10, 2022
|
@barneygale: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could try to remedy this by taking a slice, but we then run into an issue where the empty string will match altsep on POSIX. That rabbit hole could keep getting deeper.
A proper fix for the original issue involves making pathlib's path normalisation more configurable - in this case we want to retain trailing slashes, but in other we might want to preserve
./prefixes, or elide../segments when we're sure we won't encounter symlinks.This reverts commit ea2f5bc.
(cherry picked from commit dcdf250)
Co-authored-by: Barney Gale barney.gale@gmail.com
Automerge-Triggered-By: GH:brettcannon