Skip to content

bpo-34651: Only allow the main interpreter to fork. #9279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2018
Merged

bpo-34651: Only allow the main interpreter to fork. #9279

merged 6 commits into from
Sep 14, 2018

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 13, 2018 •
edited
Loading

When os.fork() is called (on platforms that support it) all threads but the current one are destroyed in the child process. Consequently we must ensure that all but the associated interpreter are likewise destroyed. The main interpreter is critical for runtime operation, so we must ensure that fork only happens in the main interpreter.

https://bugs.python.org/issue34651

@gpshead gpshead requested review from vstinner and gpshead September 13, 2018 23:06
@ericsnowcurrently ericsnowcurrently merged commit 5903296 into python:master Sep 14, 2018
@ericsnowcurrently ericsnowcurrently deleted the fork-and-subinterpreters branch September 14, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot