-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-92611: Add details on replacements for cgi utility funcs #92792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92611: Add details on replacements for cgi utility funcs #92792
Conversation
(The PR is ready for review; I've just marked it as a draft pending the resolution of the question above) |
|
||
For example, with :class:`email.message.EmailMessage`:: | ||
|
||
from email.message import EmailMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be three spaces instead of four?
It could be backported, but you would have to check all the suggestions work appropriately in the backported versions. |
039fa94
to
13fa645
Compare
Sorry for the delayed response; between recovering from PyCon, catching up on my actual work/research and helping a close family member through a difficult time, I had to take a break from most open source stuff for a bit. I confirmed the recommended replacements weren't changed between 3.9-3.11; however, in the meantime the 3.9 branch is now security-only (AFAIK). So perhaps best to just merge this as-is against 3.11+, the release where the module was formally deprecated? |
@CAM-Gerlach I'll plan to merge against 3.11 and |
Thanks @brettcannon ! |
Thanks @CAM-Gerlach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-93967 is a backport of this pull request to the 3.11 branch. |
Per @brettcannon 's suggestions on the Discourse thread, discussed in #92611 and as a followup to PR #92612 , this PR add additional specific per-function replacement information for the utility functions in the
cgi
module deprecated by PEP 594 (PEP-594).@brettcannon , should this be backported (without the
deprecated-removed
, which I would update it accordingly and re-add in my other PR adding that to the others for 3.11+), or just go in 3.11+?Automerge-Triggered-By: GH:brettcannon