Skip to content

gh-92611: Add details on replacements for cgi utility funcs #92792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented May 13, 2022

Per @brettcannon 's suggestions on the Discourse thread, discussed in #92611 and as a followup to PR #92612 , this PR add additional specific per-function replacement information for the utility functions in the cgi module deprecated by PEP 594 (PEP-594).

@brettcannon , should this be backported (without the deprecated-removed , which I would update it accordingly and re-add in my other PR adding that to the others for 3.11+), or just go in 3.11+?

Automerge-Triggered-By: GH:brettcannon

@CAM-Gerlach CAM-Gerlach requested a review from ethanfurman as a code owner May 13, 2022 23:54
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2022
@CAM-Gerlach CAM-Gerlach requested a review from brettcannon May 13, 2022 23:54
@CAM-Gerlach CAM-Gerlach marked this pull request as draft May 14, 2022 00:01
@CAM-Gerlach
Copy link
Member Author

(The PR is ready for review; I've just marked it as a draft pending the resolution of the question above)


For example, with :class:`email.message.EmailMessage`::

from email.message import EmailMessage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be three spaces instead of four?

@brettcannon
Copy link
Member

should this be backported (without the deprecated-removed , which I would update it accordingly and re-add in my other PR adding that to the others for 3.11+), or just go in 3.11+?

It could be backported, but you would have to check all the suggestions work appropriately in the backported versions.

@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review June 11, 2022 00:20
@CAM-Gerlach CAM-Gerlach force-pushed the pep-594-add-cgi-replacement-details branch from 039fa94 to 13fa645 Compare June 11, 2022 00:20
@CAM-Gerlach
Copy link
Member Author

Sorry for the delayed response; between recovering from PyCon, catching up on my actual work/research and helping a close family member through a difficult time, I had to take a break from most open source stuff for a bit.

I confirmed the recommended replacements weren't changed between 3.9-3.11; however, in the meantime the 3.9 branch is now security-only (AFAIK). So perhaps best to just merge this as-is against 3.11+, the release where the module was formally deprecated?

@brettcannon brettcannon self-assigned this Jun 15, 2022
@brettcannon
Copy link
Member

@CAM-Gerlach I'll plan to merge against 3.11 and main when I get a chance.

@CAM-Gerlach
Copy link
Member Author

Thanks @brettcannon !

@miss-islington miss-islington merged commit 71354ad into python:main Jun 17, 2022
@miss-islington
Copy link
Contributor

Thanks @CAM-Gerlach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 17, 2022
@bedevere-bot
Copy link

GH-93967 is a backport of this pull request to the 3.11 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants