Skip to content

gh-92839: fixed typo in _bisectmodule.c (line 131) #92849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from May 28, 2022
Merged

gh-92839: fixed typo in _bisectmodule.c (line 131) #92849

merged 5 commits into from May 28, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2022 •
edited by ghost
Loading

Issue #92839. Line 131 says if (x == NULL). It appears if (key_x == NULL) was intended.

I am not sure exactly what the procedure is here. The same typo exists in earlier versions of Python as well. Do we need to do anything about that?

@ghost ghost requested a review from rhettinger as a code owner May 16, 2022 12:55
@ghost
Copy link

ghost commented May 16, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost ghost mentioned this pull request May 16, 2022
Closed
@rhettinger rhettinger self-assigned this May 16, 2022
@rhettinger
Copy link
Contributor

rhettinger commented May 16, 2022 •
edited
Loading

Please add the OP's test case. And also a Misc/NEWS entry.

@ghost
Copy link
Author

ghost commented May 16, 2022 •
edited by ghost
Loading

@rhettinger Sure I can do this.

I noticed insort_left (line 259) has the same typo. I have added another commit.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes labels May 16, 2022
@sweeneyde sweeneyde added the needs backport to 3.10 only security fixes label May 17, 2022
@ghost
Copy link
Author

ghost commented May 21, 2022

@rhettinger Are these changes okay?

@rhettinger rhettinger merged commit 7fa9b7d into python:main May 28, 2022
@miss-islington
Copy link
Contributor

Thanks @oda-gitso for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @oda-gitso and @rhettinger, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7fa9b7daa5a8bb5760724ac2d94f5298c60dc905 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2022
@miss-islington
pythongh-92839: fixed typo in _bisectmodule.c (line 131) (pythonGH-92849
365740c 
)

(cherry picked from commit 7fa9b7d)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
@bedevere-bot
Copy link

GH-93321 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 28, 2022
@rhettinger rhettinger added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 28, 2022
@miss-islington
Copy link
Contributor

Thanks @oda-gitso for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 28, 2022
@bedevere-bot
Copy link

GH-93322 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2022
@miss-islington
pythongh-92839: fixed typo in _bisectmodule.c (line 131) (pythonGH-92849
cc28d98 
)

(cherry picked from commit 7fa9b7d)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 28, 2022
@miss-islington
gh-92839: fixed typo in _bisectmodule.c (line 131) (GH-92849)
85cb7f0 
(cherry picked from commit 7fa9b7d)

Co-authored-by: oda-gitso <105083118+oda-gitso@users.noreply.github.com>
rhettinger pushed a commit that referenced this pull request May 28, 2022
@miss-islington
gh-92839: fixed typo in _bisectmodule.c (line 131) (GH-92849) (#93321)
550c44b
@ghost ghost deleted the fix-issue-92839 branch May 29, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rhettinger rhettinger

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bedevere-bot @rhettinger @miss-islington @serhiy-storchaka @sweeneyde @OTheDev