gh-91755: Remove doc of C API private refcount functions #92918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions should only be used by Python internals.
|
@erlend-aasland: What do you think of removing this documentation? I don't want to backport this change, it's only for Python 3.12. |
|
AFAIK, we don't normally document private and internal API, so it looks sensible to me. |
erlend-aasland
approved these changes
May 18, 2022
|
If tomorrow Python would have a documentation for the "internal C API", I would be fine with documenting private and internal functions. But for now, I prefer to stick to only public C API functions. Thanks for the review @erlend-aasland, I merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions should only be used by Python internals.