Skip to content

bpo-33649: Refresh Tasks and Futures pages #9314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2018
Merged

bpo-33649: Refresh Tasks and Futures pages #9314

merged 3 commits into from
Sep 14, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Sep 14, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov as a code owner September 14, 2018 17:37
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Sep 14, 2018
@1st1 1st1 requested a review from willingc September 14, 2018 17:38
@1st1 1st1 added the skip news label Sep 14, 2018
willingc
willingc reviewed Sep 14, 2018
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few usability comments but overall a huge improvement 🎉

asvetlov
asvetlov approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive improvement!

willingc
willingc approved these changes Sep 14, 2018
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@willingc willingc merged commit 3faaa88 into python:master Sep 14, 2018
@bedevere-bot
Copy link

@willingc: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1st1 @bedevere-bot @asvetlov @willingc @the-knights-who-say-ni