Skip to content

gh-93600: Clarify the meaning of buffering=-1 in open() #93685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-93600: Clarify the meaning of buffering=-1 in open() #93685

wants to merge 13 commits into from
+15 −11

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Jun 10, 2022 •
edited by bedevere-bot
Loading

This commit clarify the meaning of buffering=-1 in open() function. Add
this information in Docs and in source code docstring.

@eamanu
Clarify the meaning of buffering=-1 in open()
953e515 
This commit clarify the meaning of buffering=-1 in open() function. Add
this information in Docs and in source code docstring.
@eamanu eamanu mentioned this pull request Jun 10, 2022
Open
@AA-Turner AA-Turner added docs Documentation in the Doc dir needs backport to 3.10 only security fixes topic-IO 3.12 only security fixes needs backport to 3.11 only security fixes labels Jun 10, 2022
@AA-Turner
Copy link
Member

I think you need to regenerate the frozen version of _io -- make regen-all. That should hopefully fix CI.

A

AA-Turner
AA-Turner requested changes Jun 10, 2022
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar, and a minor change from "default buffer size" to "default buffering policy" -- this ties in the following text and helps communicate that -1 is the same as passing no argument.

A

eamanu and others added 7 commits June 10, 2022 20:06
@eamanu @AA-Turner
Update Doc/library/functions.rst
5223943 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu @AA-Turner
Update Lib/_pyio.py
421e0e7 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu @AA-Turner
Update Lib/_pyio.py
b379ec9 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu @AA-Turner
Update Modules/_io/_iomodule.c
88023fb 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu @AA-Turner
Update Modules/_io/_iomodule.c
0384a43 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu @AA-Turner
Update Doc/library/functions.rst
eacc570 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@eamanu
run clinic
0ae953d
@eamanu
Copy link
Contributor Author

eamanu commented Jun 10, 2022 •
edited
Loading

HI @AA-Turner thanks for the revision. I've just push some changes, I applied the your recommendations and I pushed a commit running clinic.py, I hope that fix the build :-)

AA-Turner
AA-Turner reviewed Jun 11, 2022
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it did fix the build -- you need to re-wrap two lines though and then go through the regen dance again!

A

merwok
merwok reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@merwok merwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changes to minimize diff churn.
Lines shorter than the limit are no problem, and this keeps git history slightly more useful 🙂

eamanu and others added 3 commits August 9, 2022 07:19
@eamanu @merwok
Update Doc/library/functions.rst
3b2a188 
Apply suggestion of @merwok

Co-authored-by: Éric <merwok@netwok.org>
@eamanu @merwok
Update Lib/_pyio.py
a65f8c7 
Apply suggestion of @merwok

Co-authored-by: Éric <merwok@netwok.org>
@eamanu @merwok
Update Modules/_io/_iomodule.c
29055ca 
Apply suggestion of @merwok

Co-authored-by: Éric <merwok@netwok.org>
@eamanu
Copy link
Contributor Author

eamanu commented Aug 9, 2022

Ready thanks @merwok

merwok
merwok reviewed Aug 9, 2022
View reviewed changes
@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 7, 2023
@erlend-aasland erlend-aasland self-assigned this Jan 12, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes and removed 3.12 only security fixes needs backport to 3.11 only security fixes labels Apr 11, 2024
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 9, 2024
@willingc
Copy link
Contributor

Thanks @eamanu. It looks like the merge conflicts need to be resolved. Please ping me once they are updated. Thanks.

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@AA-Turner AA-Turner AA-Turner requested changes

Assignees

@erlend-aasland erlend-aasland

Labels
awaiting changes docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes skip news topic-IO
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eamanu @AA-Turner @willingc @merwok @hugovk @serhiy-storchaka @erlend-aasland @bedevere-bot