Skip to content

bpo-25711: Move _ZipImportResourceReader from importlib to zipimport. #9406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2018
Merged

bpo-25711: Move _ZipImportResourceReader from importlib to zipimport. #9406

merged 1 commit into from
Sep 19, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 18, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement skip news labels Sep 18, 2018
@serhiy-storchaka serhiy-storchaka requested a review from a team September 18, 2018 20:20
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 18, 2018
Merged
warsaw
warsaw approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where it's removed from the importlib source, but maybe I'm missing it. Other than that, this looks good.

@serhiy-storchaka serhiy-storchaka force-pushed the zipimport-resource-reader branch from 0164bf0 to c734452 Compare September 18, 2018 21:12
@serhiy-storchaka
Copy link
Member Author

Oh, I forgot to save these changes. Thank you for noticing this. Updated.

@serhiy-storchaka serhiy-storchaka merged commit 9da3961 into python:master Sep 19, 2018
@serhiy-storchaka serhiy-storchaka deleted the zipimport-resource-reader branch September 19, 2018 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsaw warsaw warsaw approved these changes

Assignees
No one assigned
Labels
skip news type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @warsaw @the-knights-who-say-ni @bedevere-bot