Skip to content

gh-94286 Fix documentation of print default param #94297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2022
Merged

gh-94286 Fix documentation of print default param #94297

merged 3 commits into from
Nov 6, 2022

Conversation

nouranali
Copy link
Contributor

@nouranali nouranali commented Jun 26, 2022 •
edited by iritkatriel
Loading

Fixes #94286.

@nouranali
Update functions.rst
1e49abd 
trying to solve #94286
@ghost
Copy link

ghost commented Jun 26, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jun 26, 2022
@nouranali nouranali changed the title Update functions.rst #94286 Jun 26, 2022
@nouranali nouranali changed the title #94286 gh-94286 Jun 26, 2022
@arhadthedev arhadthedev mentioned this pull request Jun 26, 2022
Closed
@merwok
Copy link
Member

merwok commented Jul 1, 2022

Hello! Please write titles for PRs so that people know what they are about from lists, notifications, etc.

@nouranali
Copy link
Contributor Author

can u provide an example?

@merwok merwok changed the title gh-94286 gh-94286 Fix documentation of print default param Jul 4, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 6, 2022
Closed
@iritkatriel iritkatriel added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 6, 2022
@iritkatriel iritkatriel merged commit 2db55e0 into python:main Nov 6, 2022
@miss-islington
Copy link
Contributor

Thanks @nouranali for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99173 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 6, 2022
@bedevere-bot
Copy link

GH-99174 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@nouranali @miss-islington
pythongh-94286 Fix documentation of print default param (pythonGH-94297)
d1aaba6 
(cherry picked from commit 2db55e0)

Co-authored-by: Nouran Ali <nouranalimohammed@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@nouranali @miss-islington
pythongh-94286 Fix documentation of print default param (pythonGH-94297)
7531de8 
(cherry picked from commit 2db55e0)

Co-authored-by: Nouran Ali <nouranalimohammed@gmail.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @nouranali
gh-94286 Fix documentation of print default param (GH-94297)
8eb4e2c 
(cherry picked from commit 2db55e0)

Co-authored-by: Nouran Ali <nouranalimohammed@gmail.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @nouranali
gh-94286 Fix documentation of print default param (GH-94297)
c4408d3 
(cherry picked from commit 2db55e0)

Co-authored-by: Nouran Ali <nouranalimohammed@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The documentation for the print() builtin should perhaps say file=None as default
7 participants
@nouranali @bedevere-bot @merwok @miss-islington @DanielNoord @iritkatriel @hauntsaninja