-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
gh-78319: add UTF8 marker per RFC #9436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@gordonmessmer tests are failing (see |
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
36fd655
to
41c490e
Compare
I'll look at it again, yes. I'm getting odd results from updated tests, so some additional work is still needed... |
c116b76
to
633ad44
Compare
Tests look like they're passing, but trying this on a live IMAP server fails, because the server actually receives:
... when Sam suggested that it should receive:
But that's probably a larger bug in the imaplib module, and not directly related to this change. |
I've asked Sam to chime in. The RFC calls those arguments optional. Based on its behavior, it seems that Courier expects them to be specified as NIL when they are not provided, rather than left out entirely. |
I added a commit for consideration. Transforming None to "NIL" is RFC-compliant (which is consistent with the intent of this PR). Tests pass, and this works with Courier IMAP. |
7af0319
to
6726e07
Compare
The NIL requirement may be a bug in Courier (ironically also caused by UTF8 support), so the "imaplib: transform None into "NIL"" patch might not be needed. Everything else looks good, I think. |
6726e07
to
f007fdf
Compare
f007fdf
to
81faa3c
Compare
Sam released a new version of Courier, and I've verified that the None->NIL transformation is no longer necessary, so I've backed it out. |
Please let me know if there's anything I can do to help move this forward. |
This PR is stale because it has been open for 30 days with no activity. |
Please let me know if there's anything I can do to help move this forward. |
This PR is stale because it has been open for 30 days with no activity. |
This change implements RFC 6855 UTF8 APPEND per guidance from Sam Varshavchik:
https://bugs.python.org/issue34138
https://bugs.python.org/issue34138