Skip to content

GH-94644: fix test_curses ref leak #94647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jul 7, 2022

Automerge-Triggered-By: GH:tiran

@tiran
Copy link
Member

tiran commented Jul 7, 2022

Thanks for the fix!

I have removed the "closes" line. The PR fixes the refleak but not the missing HAVE_NCURSEW problem.

@tiran tiran added 3.11 only security fixes 3.12 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Jul 7, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94653 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94654 is a backport of this pull request to the 3.10 branch.

@kumaraditya303 kumaraditya303 deleted the ref-leak branch July 7, 2022 11:12
miss-islington added a commit that referenced this pull request Jul 7, 2022
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jul 7, 2022
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes 3.12 only security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants