GH-90927: docs for asyncio.timeout and task cancellation #94794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gvanrossum @CAM-Gerlach I have not yet had the chance to address all the feedback from the last PR, but here's the new one. |
gvanrossum
reviewed
Jul 13, 2022
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
|
Ok, ready for some more review. How do we feel about type hints in the API docs? I think they look nice.
|
|
Yeah, annotations are fine here IMO. |
gvanrossum
approved these changes
Jul 15, 2022
|
Sorry, I can't merge this PR. Reason: |
|
Thanks @Tinche for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2022
…nGH-94794) (cherry picked from commit 08f6897) Co-authored-by: Tin Tvrtković <tinchester@gmail.com>
|
GH-94870 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 15, 2022
|
Thanks for managing this @gvanrossum , it was my pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docs for
asyncio.timeout,asyncio.timeout_atand a short section on asyncio cancellation.Automerge-Triggered-By: GH:gvanrossum