bpo-34537: Fix test_gdb:test_strings with LC_ALL=C #9483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot simply call locale.getpreferredencoding() here, as GDB might have been linked against a different version of Python with a different encoding and coercion policy with respect to PEP 538 and PEP 540. Thanks to Victor Stinner for a hint on how to fix this.
vstinner
approved these changes
Sep 21, 2018
| @@ -0,0 +1,2 @@ | |||
| Fix test_gdb:test_strings when LC_ALL=C and GDB was compiled with Python 3.6 | |||
There was a problem hiding this comment.
I suggest "test_gdb.test_strings()" or "test_strings() of test_gdb". You might use `` around function and file names.
Lib/test/test_gdb.py
Outdated
| if err: | ||
| raise RuntimeError( | ||
| 'unable to determine the preferred encoding ' | ||
| 'of embedded Python in GDB.') |
There was a problem hiding this comment.
Would you mind to include err in the error message? You can use an f-string.
You might also raise the error if encoding is an empty string (if err or not encofing: ...)
Lib/test/test_gdb.py
Outdated
| 'unable to determine the preferred encoding ' | ||
| 'of embedded Python in GDB.') | ||
|
|
||
| encoding = out.strip() |
There was a problem hiding this comment.
.rstrip() should be enough ;-)
vstinner
reviewed
Sep 21, 2018
Lib/test/test_gdb.py
Outdated
| if not encoding: | ||
| raise RuntimeError( | ||
| f'unable to determine the preferred encoding ' | ||
| f'of embedded Python in GDB: the command returned no output') |
There was a problem hiding this comment.
Oh, I don't think that we need two code path, just reuse the first if.
There was a problem hiding this comment.
I mean, the first error message is fine if encoding is an empty string.
vstinner
approved these changes
Sep 22, 2018
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 22, 2018
We cannot simply call locale.getpreferredencoding() here, as GDB might have been linked against a different version of Python with a different encoding and coercion policy with respect to PEP 538 and PEP 540. Thanks to Victor Stinner for a hint on how to fix this. (cherry picked from commit 7279b51) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
|
GH-9485 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 22, 2018
We cannot simply call locale.getpreferredencoding() here, as GDB might have been linked against a different version of Python with a different encoding and coercion policy with respect to PEP 538 and PEP 540. Thanks to Victor Stinner for a hint on how to fix this. (cherry picked from commit 7279b51) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot simply call locale.getpreferredencoding() here,
as GDB might have been linked against a different version
of Python with a different encoding and coercion policy
with respect to PEP 538 and PEP 540.
Thanks to Victor Stinner for a hint on how to fix this.
https://bugs.python.org/issue34537