gh-95010: fix asyncio GenericWatcherTests.test_create_subprocess_fails_with_inactive_wa… #95009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
823b0c4 to
9877b92
Compare
|
this is just a test change and doesn't need news |
…s_fails_with_inactive_watcher the test was never run, because it was missing the TestCase class the test failed because the wrong attribute was patched
4f47e21 to
20b9bd0
Compare
|
It's best to review this in side-by-side mode, because GenericWatcherTests needed to be indented: https://github.com/python/cpython/pull/95009/files?diff=split |
|
This should probably be backported to 3.10 as it's needed to verify a bugfix |
|
Thanks @graingert for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-95092 is a backport of this pull request to the 3.11 branch. |
|
GH-95093 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2022
…s_fails_with_inactive_watcher (pythonGH-95009) The test was never run, because it was missing the TestCase class. The test failed because the wrong attribute was patched. (cherry picked from commit 834bd5d) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2022
…s_fails_with_inactive_watcher (pythonGH-95009) The test was never run, because it was missing the TestCase class. The test failed because the wrong attribute was patched. (cherry picked from commit 834bd5d) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix asyncio
GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcherthe test was never run, because it was missing the TestCase class
the test failed because the wrong attribute was patched
GenericWatcherTests.test_create_subprocess_fails_with_inactive_watcheris not run #95010