gh-95097: support custom tasks with missing uncancel methods #95098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70c5a25 to
e0dc28b
Compare
graingert
commented
Jul 21, 2022
graingert
commented
Jul 21, 2022
graingert
commented
Jul 21, 2022
graingert
commented
Jul 21, 2022
| @@ -67,14 +67,30 @@ def _set_task_name(task, name): | |||
| try: | |||
| set_name = task.set_name | |||
There was a problem hiding this comment.
If a task is missing set_name it's probably missing uncancel
c5bab57 to
198cf7a
Compare
198cf7a to
c15439a
Compare
kumaraditya303
requested changes
Jul 24, 2022
|
Closing as the issue was fixed by #95211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeError: 'Task' object has no attribute 'uncancel'. Did you mean: 'cancel'?when the asyncioloop.set_task_factoryfactory returns aasyncio.Future-compatible object #95097